SCALRCORE-31246: Add API operations for RunScheduleRule resource #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyzohub
changed the title
run_schedule_rule.go
Outdated
| // RunScheduleRuleUpdateOptions represents the options for updating a run schedule rule. | ||
| type RunScheduleRuleUpdateOptions struct { | ||
| ID string `jsonapi:"primary,run-schedule-rules"` | ||
| Schedule string `jsonapi:"attr,schedule"` |
There was a problem hiding this comment.
Optional parameters should be declared as pointers with omitempty tag, so empty values are not passed in update request.
run_schedule_rule.go
Outdated
Comment on lines
133
to
134
| Schedule string `jsonapi:"attr,schedule,omitempty"` | ||
| ScheduleMode ScheduleMode `jsonapi:"attr,schedule-mode,omitempty"` |
There was a problem hiding this comment.
Suggested change
| Schedule string `jsonapi:"attr,schedule,omitempty"` | |
| ScheduleMode ScheduleMode `jsonapi:"attr,schedule-mode,omitempty"` | |
| Schedule *string `jsonapi:"attr,schedule,omitempty"` | |
| ScheduleMode *ScheduleMode `jsonapi:"attr,schedule-mode,omitempty"` |
petroprotsakh
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.