Skip to content

Commit

Permalink
SCALRCORE-30839 add deprecation for the 'secret-key' attr of 'scalr_w…
Browse files Browse the repository at this point in the history
…ebhook' datasource
  • Loading branch information
RomanMytsko committed May 22, 2024
1 parent ab28d2d commit b53506e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Deprecated

- `data.scalr_webhook`: attribute `secret_key` is deprecated and will be removed in the next major version ([#313](https://github.com/Scalr/terraform-provider-scalr/pull/313))

### Added

- `scalr_slack_integration`: new attribute `run_mode` ([#300](https://github.com/Scalr/terraform-provider-scalr/pull/300))
Expand Down
2 changes: 1 addition & 1 deletion docs/data-sources/webhook.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ data "scalr_webhook" "example2" {
- `header` (Set of Object) Additional headers to set in the webhook request. (see [below for nested schema](#nestedatt--header))
- `last_triggered_at` (String) Date/time when webhook was last triggered.
- `max_attempts` (Number) Max delivery attempts of the payload.
- `secret_key` (String, Sensitive) Secret key to sign the webhook payload.
- `secret_key` (String, Sensitive, Deprecated) Secret key to sign the webhook payload.
- `timeout` (Number) Endpoint timeout (in seconds).
- `url` (String) Endpoint URL.
- `workspace_id` (String, Deprecated) ID of the workspace, in the format `ws-<RANDOM STRING>`.
Expand Down
2 changes: 2 additions & 0 deletions scalr/data_source_scalr_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ func dataSourceScalrWebhook() *schema.Resource {
Type: schema.TypeString,
Computed: true,
Sensitive: true,
Deprecated: "Attribute `secret_key` is deprecated, the secret-key has sensitive data" +
" and is not returned by the API.",
},

"timeout": {
Expand Down

0 comments on commit b53506e

Please sign in to comment.