Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #220 Screen Mirroring Functionality #221

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

sameerjj
Copy link
Contributor

  • modify sample/ar-cursor-placement code to have MediaRecorder functionality based on action button
    • because of the MediaPlayer state machine, I wasn't able to use sceneView.startRecording() directly as it wasn't possible to configure it correctly (setVideoSource, setOutputFile, setVideoEncoder had to be called in a very specific order)
  • modify SceneView to use a more generic startMirroring() function and not try to do too much MediaPlayer related activity.
  • render.copyFrame() has to be called between renderer.render(view) and renderer.endFrame() add screenMirror call there
  • modify ScreenMirrorer to not depend on lifecycle but rather manual call from SceneView.

TODO could getLetterboxViewport be moved to startMirroring?

@sameerjj sameerjj changed the title #220 Fix Screen Mirroring Functionality Fixes #220 Screen Mirroring Functionality Feb 15, 2023
@ThomasGorisse ThomasGorisse merged commit 68111c6 into SceneView:main Feb 20, 2023
@ThomasGorisse
Copy link
Contributor

Thanks @sameerjj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants