Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs Fix: Editor Settings Menu #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CelsiaSolaraStarflare
Copy link
Collaborator

Added Settings Tab to the editor[Menu>Edit>Editor Settings]. Defines the color, bgcolor, fontsize, and font of the editor(defaulted at every time the program is initialized). NEEDS FIX: The program now has self object defined for the text stuff, however they do not init at the start of the program.
Screenshot 2024-01-06 at 12 16 58 AM

Added Settings to the editor. Defines the color, bgcolor, fontsize, and font of the editor(defaulted at every time the program is initialized). 
NEEDS FIX: The program now has self object defined for the text stuff, however they do not init at the start of the program.
@CelsiaSolaraStarflare CelsiaSolaraStarflare changed the title NEEDS FIX: updated main.py Needs Fix: updated main.py Jan 5, 2024
@CelsiaSolaraStarflare CelsiaSolaraStarflare changed the title Needs Fix: updated main.py Needs Fix: Editor Settings Menu Jan 5, 2024
Copy link
Owner

@SchBenedikt SchBenedikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!
Do you want to use this to set default settings?

In any case, I can't try this because I always get the error:

Traceback (most recent call last):
  File "C:\Users\bened\Documents\Text-Editor-main\main.py", line 201, in show_settings
    fontsize_input = QLineEdit(str(settings[2]))
                                   ~~~~~~~~^^^
IndexError: list index out of range

Do you know what that could be?

@CelsiaSolaraStarflare
Copy link
Collaborator Author

CelsiaSolaraStarflare commented Jan 6, 2024

I think maybe we can add a defaulted settings to the project, like if someone is constantly doing book typesetting they would use Crimson font 10pt a lot and if a person is constantly with academic essays then Times New Roman 12 pt. They can still change the settings onwards though.
\\\\\\
Oh sorry I think it is because I didn't include the settings.txt file.
The file right now is in the format:
[textcolor:]R,G,B
[textbackgroundcolor:]R,G,B
[Fontsize] an interger
[Font] "Font Family Name"

This example should work. However, the automatically create the settings.txt action needs to be fixed too.
settings.txt

@CelsiaSolaraStarflare CelsiaSolaraStarflare self-assigned this Jan 6, 2024
@CelsiaSolaraStarflare CelsiaSolaraStarflare added the help wanted Extra attention is needed label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants