Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for protobuf breaking changes only against master branch #125

Closed
2 tasks done
linuxluigi opened this issue May 25, 2022 · 0 comments · Fixed by #136
Closed
2 tasks done

Check for protobuf breaking changes only against master branch #125

linuxluigi opened this issue May 25, 2022 · 0 comments · Fixed by #136
Assignees
@linuxluigi @brumhard
Labels
bug Something isn't working

Comments

@linuxluigi
Copy link
Collaborator

What happened?

When creating a project with gRPC support, the command make protobreaking checks only against master branch.
Better would be checking against the current main branch and not hard-coded a specific branch.

How can we reproduce this?

Create a new project with gRPC support and run make protobreaking where no master branch exists.

gt version

0.4.0

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linuxluigi linuxluigi

@brumhard brumhard

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(template): change branch name in protobreaking from master to main (#125) SchwarzIT/go-template
2 participants
@linuxluigi @brumhard