Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): use projectSlug as default for appName #14

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

eljoth
Copy link
Contributor

@eljoth eljoth commented Oct 2, 2021

Working with the template, I encountered the following:

linting the repository that just was created, the linter errors due to not handling the error from the logger.Sync() call.

Error return value of `logger.Sync` is not checked (errcheck)
        defer logger.Sync()
                         ^

In addition I think it is more convenient to start with a cmd/{{.projectName}} instead of cmd/awesomecli if nothing else is specified.

@linuxluigi
Copy link
Collaborator

Thanks for you contribution, looks good for me 👍

_template/cmd/{{.appName}}/main.go Outdated Show resolved Hide resolved
options.yml Outdated Show resolved Hide resolved
Signed-off-by: Tobias Brumhard <tobias.brumhard@mail.schwarz>
@brumhard brumhard changed the title Feature/minor improvements feat(template): use projectSlug as default for appName Jan 28, 2022
@brumhard
Copy link
Contributor

@eljoth I rebased your change to use the projectSlug as default for appName onto the new way of defining options. Hope you don't mind, thanks for the contribution 👍🏻
Fixes #54.

@brumhard brumhard merged commit 6c0a7db into main Jan 28, 2022
@brumhard brumhard deleted the feature/minor-improvements branch January 28, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants