fix(nuxt): require locale mapping for i18n integration #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 459a9d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markbrockhoff
force-pushed
the
nuxt/fix-locale-registration
branch
from
1de527f
to
0450992
Compare
larsrickert
requested changes
Jul 1, 2024
markbrockhoff
force-pushed
the
nuxt/fix-locale-registration
branch
from
0450992
to
540a39f
Compare
markbrockhoff
force-pushed
the
nuxt/fix-locale-registration
branch
from
540a39f
to
459a9d0
Compare
larsrickert
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the registration order warning of the nuxt module.
It also requires the user to specify a mapping for onyx locales to the locales from nuxt-i18n specific to their project.
This fixes a bug where all projects would display all locales of onyx as supported languages even if they were not specified within the project.
An issue and PR were already created for nuxt-i18n to support loading locales from npm packages. (nuxt-modules/i18n#2999)
This way it would be possible to decouple onyx and nuxt-i18n while preserving easy support and customizability. This PR should make the onyx module useable until the feature is available inside nuxt-i18n.
Checklist
apps/docs)npx changeset addif your changes should be released as npm package (because they affect the library usage)