Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify what is using in SpecialMatrices #12

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Specify what is using in SpecialMatrices #12

merged 1 commit into from
Dec 27, 2022

Conversation

JeffFessler
Copy link
Contributor

Hi, I am helping maintain SpecialMatrices.jl and we are making some possibly breaking changes over there and we wanted to make sure they won't break registered packages that depend on it. This is one of 2 such packages.
It took a while to figure out what you are actually using here from SM.
I know it is pretty common to just drop a lot of using XYZ statements in the main project file,
but that approach makes it hard for others to know what specifically is being used here.
This PR simply makes it clear. Thanks.

@JeffFessler
Copy link
Contributor Author

I just noticed that your sister package makes it specific already - thanks!
https://github.com/SciFracX/FractionalDiffEq.jl/blob/80fcd07d63d2b9ca9332317819272d0e7fb1b0df/src/FractionalDiffEq.jl#L7

@JeffFessler
Copy link
Contributor Author

Bump 🙂

@ErikQQY
Copy link
Member

ErikQQY commented Dec 27, 2022

Hi there! Sorry for the late response, I've been very busy lately. Thanks a lot!

@ErikQQY ErikQQY merged commit e6926b4 into SciFracX:master Dec 27, 2022
@JeffFessler JeffFessler deleted the jf/using branch December 27, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants