Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs1 #178

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Docs1 #178

merged 2 commits into from
Sep 23, 2023

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member

@sathvikbhagavan do you know what introduced that test error?

@ArnoStrouwen
Copy link
Member Author

It is not uncommon for the formatter to eat something on the first format. I'll have to go through it in detail.

@sathvikbhagavan
Copy link
Member

sathvikbhagavan commented Sep 23, 2023

Formatting is not the issue here.
QuadGK@2.9 seems to be the problem. Tests pass with QuadGK@2.8.
Tried this in #179

@ChrisRackauckas
Copy link
Member

Can you upper bound, isolate and open an issue?

@ChrisRackauckas ChrisRackauckas merged commit 13e1192 into SciML:master Sep 23, 2023
3 of 7 checks passed
@ArnoStrouwen ArnoStrouwen deleted the docs1 branch September 23, 2023 15:24
@stevengj
Copy link
Contributor

stevengj commented Sep 23, 2023

Should be fixed shortly (JuliaRegistries/General#92061).

The source of the problem was a dispatch snafu because your LinearInterpolation is a subtype of AbstractVector, which seems a bit weird to me. (The elements of the vector are apparently the abscissae followed by the ordinates?) This behavior doesn't seem to be documented — are you sure you want to expose it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants