Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CubaSUAVE returning wrong result, NaN #17

Closed
agerlach opened this issue Jun 1, 2020 · 2 comments
Closed

CubaSUAVE returning wrong result, NaN #17

agerlach opened this issue Jun 1, 2020 · 2 comments

Comments

@agerlach
Copy link
Collaborator

agerlach commented Jun 1, 2020

suave() from Cuba.jl is not handling large maxiters properly. See issue.

Currently Quadtrature.jl sets by default, maxiters = typemax(Int). I recommend changing the default to the default used by Cuba.jl, maxiters = 1000000
@ChrisRackauckas
Copy link
Member

Interesting that it needs needs. Yeah, setting the default maxiters so it works would be good.

ChrisRackauckas added a commit that referenced this issue Jun 2, 2020
@ChrisRackauckas
Set maxiters for CubaSUAVE
f4a032c 
Fixes #17
@ChrisRackauckas ChrisRackauckas mentioned this issue Jun 2, 2020
Closed
@agerlach
Copy link
Collaborator Author

agerlach commented Jun 5, 2020

This is fixed in #20

@agerlach agerlach closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set maxiters for CubaSUAVE SciML/Integrals.jl
2 participants
@agerlach @ChrisRackauckas