Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop fastmaths #266

Merged
merged 3 commits into from
Sep 7, 2022
Merged

drop fastmaths #266

merged 3 commits into from
Sep 7, 2022

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Sep 6, 2022

I keep thinking we should drop these and then forgetting, so I'm putting it through now before I forget again...

@ChrisRackauckas
Copy link
Member

What was the effect of these ones? Some should just be replaced with @muladd?

@isaacsas
Copy link
Member Author

isaacsas commented Sep 6, 2022

@ChrisRackauckas has something changed with how the kwargs in a problem get passed through to solve recently? The test error seems to arise from the callback not getting propagated anymore to the solve call.

@isaacsas isaacsas closed this Sep 7, 2022
@isaacsas isaacsas reopened this Sep 7, 2022
@isaacsas
Copy link
Member Author

isaacsas commented Sep 7, 2022

@ChrisRackauckas does this look ok to you now with add_fast being used in those previously @fastmath functions?

@ChrisRackauckas
Copy link
Member

yes

@ChrisRackauckas ChrisRackauckas merged commit 222acf1 into SciML:master Sep 7, 2022
@isaacsas isaacsas deleted the drop_fastmath branch September 7, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaacsas @ChrisRackauckas