Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unbound type parameters #267

Merged
merged 1 commit into from
Sep 8, 2022
Merged

remove unbound type parameters #267

merged 1 commit into from
Sep 8, 2022

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Sep 8, 2022

Unbound type parameters often cause performance issues and run time dispatch.

Issue found using JuliaLang/julia#46608

Unbound type parameters often cause performance issues and run time
dispatch.

Issue found using JuliaLang/julia#46608
@coveralls
Copy link

coveralls commented Sep 8, 2022

Pull Request Test Coverage Report for Build 3018041945

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+1.2%) to 88.879%

Files with Coverage Reduction New Missed Lines %
src/aggregators/prioritytable.jl 1 86.86%
src/extended_jump_array.jl 1 31.88%
src/jumps.jl 1 87.28%
src/coupling.jl 2 78.18%
src/spatial/spatial_massaction_jump.jl 3 85.45%
Totals Coverage Status
Change from base Build 3009189274: 1.2%
Covered Lines: 1942
Relevant Lines: 2185

💛 - Coveralls

@ChrisRackauckas ChrisRackauckas merged commit 23aa6ac into SciML:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants