-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework iparm setting #505
Rework iparm setting #505
Conversation
Pardiso defaults for highly indefinite matrices. This commit essentially reverts SciML#89 and introduces a new kwarg "cache_analysis" (default `false`) to PardisoJL() which, if true would lead to the behaviour of SciML#89. Also, allow the user to overwrite all iparms modified by the extension besides of 12.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 62.71% 62.72% +0.01%
==========================================
Files 29 29
Lines 2229 2235 +6
==========================================
+ Hits 1398 1402 +4
- Misses 831 833 +2 ☔ View full report in Codecov by Sentry. |
Looks like some of the Pardiso tests are failing from this? |
* iparm 12 -> 2 (transposed vs conjugate) * iparm 4 instead of 3 for reltol
Panua Pardiso seems to depend on calling pardisoinit first.
Otherwise Panua Pardiso may segfault during iteration for complex system
Well, they did fail on master before... |
Once this PR is merged I would prepare another one which should allow to choose form both pardiso flavors from the code. Now, just Panua is chosen over MKL if it is installed. |
Thanks! |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This tries to fix #497
Pardiso defaults for highly indefinite matrices.
This commit essentially reverts #89 and introduces a new
kwarg "cache_analysis" (default
false
) to PardisoJL() which, if true wouldlead to the behaviour of #89.
Also, allow the user to overwrite all iparms modified by
the extension besides of 12.
Fixes also a problem found by @chmerdon