Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for a future with multiple discretization strategies #185

Merged
merged 10 commits into from
Nov 2, 2022

Conversation

xtalax
Copy link
Member

@xtalax xtalax commented Nov 2, 2022

Make way for the stencil interface discretization strategy

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #185 (f4618bf) into master (f57c44e) will decrease coverage by 15.90%.
The diff coverage is 71.18%.

@@             Coverage Diff             @@
##           master     #185       +/-   ##
===========================================
- Coverage   84.67%   68.76%   -15.91%     
===========================================
  Files          33       35        +2     
  Lines        1664     1681       +17     
===========================================
- Hits         1409     1156      -253     
- Misses        255      525      +270     
Impacted Files Coverage Δ
src/interface/solution/MOLMetadata.jl 88.88% <ø> (-11.12%) ⬇️
src/system_parsing/interior_map.jl 91.60% <57.14%> (-8.40%) ⬇️
src/scalar_discretization.jl 66.66% <66.66%> (ø)
src/MOL_discretization.jl 59.63% <88.88%> (-5.34%) ⬇️
src/discretization/generate_ic_defaults.jl 86.66% <100.00%> (-6.67%) ⬇️
src/interface/MOLFiniteDifference.jl 90.00% <100.00%> (ø)
src/interface/disc_strategy_types.jl 100.00% <100.00%> (ø)
src/interface/solution/timeindep.jl 0.00% <0.00%> (-100.00%) ⬇️
...tization/schemes/half_offset_centred_difference.jl 0.00% <0.00%> (-100.00%) ⬇️
...schemes/nonlinear_laplacian/nonlinear_laplacian.jl 41.93% <0.00%> (-58.07%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xtalax xtalax merged commit 0e3eccc into SciML:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant