avoid n^2 scaling in expand_instream #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, the connection set that belongs to an instream expression was found by looping over all of them. With n expressions and n connection sets, the time this took for large systems became very large (at least a day for me). This fixes that by creating a Dict that maps directly to the required connection set. This Dict is created by looping over all connection sets once.
YingboMa
reviewed
Jan 25, 2023
|
When adding the tests, did you make sure that they return the same expressions as before? |
Co-authored-by: Yingbo Ma <mayingbo5@gmail.com>
|
Yes I ran these tests both with and without the changes, both passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the connection set that belongs to an instream expression was found by looping over all of them. With n expressions and n connection sets, the time this took for large systems became very large (at least a day for me). This fixes that by creating a Dict that maps directly to the required connection set. This Dict is created by looping over all connection sets once.