Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for FastBroadcast to 0.3, (keep existing compat) #434

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the FastBroadcast package from 0.2.8 to 0.2.8, 0.3.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.49%. Comparing base (86bb307) to head (00b4423).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #434       +/-   ##
===========================================
- Coverage   86.46%   54.49%   -31.97%     
===========================================
  Files          47       47               
  Lines        2904     2901        -3     
===========================================
- Hits         2511     1581      -930     
- Misses        393     1320      +927     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal closed this May 24, 2024
@avik-pal avik-pal reopened this May 24, 2024
@avik-pal avik-pal closed this May 25, 2024
@avik-pal avik-pal reopened this May 25, 2024
@chriselrod
Copy link
Contributor

chriselrod commented May 25, 2024

@avik-pal I've not looked at all the failures, but the ones I did look at were due to incompatible versions.
I.e., other packages also depend on FastBroadcast.jl, but haven't had their patch versions bumped.

I think we should release a package that passes tests, and not care about failures due to version incompatibilities. E.g., someone installing OrdinaryDiffEq will safely get an older FastBroadcast, and thus won't experience breakages.
When it comes to the downstream packages tests, if they do encounter failures, we can fix them in e.g. FastBroadcast 0.3.1, and then add that as the compat there.

If you saw real test failures among these, please let me know.

@avik-pal avik-pal closed this May 25, 2024
@avik-pal avik-pal reopened this May 25, 2024
@avik-pal
Copy link
Member

@chriselrod just to confirm, there are no API changes in FastBroadcast, right? From the commits it seems to be mostly an internal implementation detail that changed

@chriselrod
Copy link
Contributor

@chriselrod just to confirm, there are no API changes in FastBroadcast, right? From the commits it seems to be mostly an internal implementation detail that changed

No API change. It was a major internal change, so there is a risk of accidental/unintended breakage. That is the reason I cautiously made the release breaking.

@avik-pal avik-pal merged commit 4952a0c into master May 25, 2024
21 of 48 checks passed
@avik-pal avik-pal deleted the compathelper/new_version/2024-05-24-16-06-03-734-02112062549 branch May 25, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants