fix: don't use similar on prototype #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have opened JuliaDiff/DifferentiationInterface.jl#544 to discuss if the same should be done for DI |
|
As shown in that issue, you take a possibly big performance hit by using your copy. I think it would make more sense to fix the similar semantics for banded arrays |
|
Specifically this is for FastAlmostBandedMatrices and not BandedMatrices |
|
See, this is so specific I don't think it warrants a performance and generality decrease overall |
|
Whether this is done or not, FastAlmostBandedMatrices should fix its similar dispatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.