-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pseudo-Symplectic Explicit Runge-Kutta methods #2174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Did you check whether dense output works nicely, e.g., by plotting some numerical solutions?
What's left here? |
I added proper testing, everything should be fine right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This implements some methods mentioned in #1987
references
I just did the ode_convergence_test locally. Please, let me know if any other tests are required. Thank you!