Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pseudo-Symplectic Explicit Runge-Kutta methods #2174

Merged
merged 5 commits into from
May 12, 2024

Conversation

MarcoArtiano
Copy link
Contributor

@MarcoArtiano MarcoArtiano commented Apr 24, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This implements some methods mentioned in #1987

references

 "@article{Aubry1998,
    author = {A. Aubry and P. Chartier},
    journal = {BIT Numer. Math.},
    title =  {Pseudo-symplectic {R}unge-{K}utta methods},
    volume = {38},
    PAGES = {439-461},
    year = {1998},
    },
    https://link.springer.com/article/10.1007/BF02510253
    @article{Capuano2017,
    title = {Explicit {R}unge–{K}utta schemes for incompressible flow with improved energy-conservation properties},
    journal = {J. Comput. Phys.},
    volume = {328},
    pages = {86-94},
    year = {2017},
    issn = {0021-9991},
    doi = {https://doi.org/10.1016/j.jcp.2016.10.040},
    author = {F. Capuano and G. Coppola and L. Rández and L. {de Luca}},}"

I just did the ode_convergence_test locally. Please, let me know if any other tests are required. Thank you!

@MarcoArtiano MarcoArtiano changed the title Adding new Pseudo-Symplectic Explicit Runge-Kutta methods Adding Pseudo-Symplectic Explicit Runge-Kutta methods Apr 24, 2024
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
src/caches/low_order_rk_caches.jl Outdated Show resolved Hide resolved
src/perform_step/low_order_rk_perform_step.jl Outdated Show resolved Hide resolved
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Did you check whether dense output works nicely, e.g., by plotting some numerical solutions?

src/alg_utils.jl Outdated Show resolved Hide resolved
test/algconvergence/ode_convergence_tests.jl Outdated Show resolved Hide resolved
src/alg_utils.jl Show resolved Hide resolved
src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
src/algorithms/explicit_rk.jl Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member

What's left here?

@MarcoArtiano
Copy link
Contributor Author

What's left here?

I added proper testing, everything should be fine right now.

src/alg_utils.jl Outdated Show resolved Hide resolved
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChrisRackauckas ChrisRackauckas merged commit d02f963 into SciML:master May 12, 2024
26 of 32 checks passed
@MarcoArtiano MarcoArtiano mentioned this pull request May 13, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants