Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PositiveIntegrators.jl to downstream tests #2281

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jul 13, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

@ChrisRackauckas As discussed at JuliaCon yesterday, I added the package https://github.com/SKopecz/PositiveIntegrators.jl to the downstream tests of OrdinaryDiffEq.jl to ensure that we stay compatible with internal changes done here.

@ranocha
Copy link
Member Author

ranocha commented Jul 13, 2024

Only the codecov part of the new downstream test failed

@ChrisRackauckas
Copy link
Member

Interesting, codecov should be disabled. I'll have to look into that.

@ChrisRackauckas ChrisRackauckas merged commit 6ece080 into master Jul 13, 2024
30 of 35 checks passed
@ChrisRackauckas ChrisRackauckas deleted the hr/downstream_PositiveIntegrators branch July 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants