Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop units in eigen_est, since internalnorm drops units #645

Merged
merged 3 commits into from
Mar 19, 2019

Conversation

YingboMa
Copy link
Member

@YingboMa YingboMa commented Feb 4, 2019

No description provided.

@devmotion
Copy link
Member

devmotion commented Feb 4, 2019

Just noticed that https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl/blob/master/src/perform_step/low_order_rk_perform_step.jl#L781 causes a type instability, as far as I can see. I guess it should be ϱu, ϱd = zero(eltype(k7))^2, zero(eltype(g7))^2?

@YingboMa
Copy link
Member Author

Bump

@ChrisRackauckas
Copy link
Member

Rebase first.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.7%) to 76.34% when pulling 354ea3c on myb/unit into 18deef4 on master.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #645 into master will increase coverage by 4.3%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #645     +/-   ##
=========================================
+ Coverage   68.39%   72.69%   +4.3%     
=========================================
  Files          93       93             
  Lines       29161    29177     +16     
=========================================
+ Hits        19945    21211   +1266     
+ Misses       9216     7966   -1250
Impacted Files Coverage Δ
src/solve.jl 91.37% <100%> (+0.04%) ⬆️
src/perform_step/low_order_rk_perform_step.jl 98.7% <50%> (ø) ⬆️
src/algorithms.jl 98.26% <0%> (+0.03%) ⬆️
src/dense/interpolants.jl 98.56% <0%> (+0.11%) ⬆️
src/alg_utils.jl 33.66% <0%> (+0.74%) ⬆️
src/initdt.jl 92.95% <0%> (+1.4%) ⬆️
src/integrators/integrator_utils.jl 88.77% <0%> (+1.47%) ⬆️
src/dense/generic_dense.jl 71.84% <0%> (+3.78%) ⬆️
src/caches/low_order_rk_caches.jl 89.04% <0%> (+7.22%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18deef4...354ea3c. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 01c54e0 into master Mar 19, 2019
@ChrisRackauckas ChrisRackauckas deleted the myb/unit branch March 19, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants