Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iscomplex type param to PDESolutions #361

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xtalax
Copy link
Member

@xtalax xtalax commented Jan 9, 2023

No description provided.

@ChrisRackauckas
Copy link
Member

What is this? And won't other constructors need to be updated for this?

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #361 (71487a2) into master (0235a49) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   57.46%   57.45%   -0.01%     
==========================================
  Files          43       43              
  Lines        3289     3291       +2     
==========================================
+ Hits         1890     1891       +1     
- Misses       1399     1400       +1     
Impacted Files Coverage Δ
src/solutions/pde_solutions.jl 0.00% <0.00%> (ø)
src/retcodes.jl 31.57% <0.00%> (-3.51%) ⬇️
src/integrator_interface.jl 45.51% <0.00%> (-1.67%) ⬇️
src/interpolation.jl 32.95% <0.00%> (-0.39%) ⬇️
src/solutions/solution_interface.jl 59.25% <0.00%> (ø)
src/ensemble/ensemble_analysis.jl 79.50% <0.00%> (+0.81%) ⬆️
src/ensemble/basic_ensemble_solve.jl 81.73% <0.00%> (+0.96%) ⬆️
src/solutions/ode_solutions.jl 93.93% <0.00%> (+2.02%) ⬆️
src/operators/common_defaults.jl 67.64% <0.00%> (+2.94%) ⬆️
src/tabletraits.jl 73.33% <0.00%> (+10.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xtalax
Copy link
Member Author

xtalax commented Jan 17, 2023

Just something to dispatch on for when the solution is complex, though on second thought I could do this with the metadata.

Is anyone else using these yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants