Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ensemble indexing in the plot recipe #602

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

SebastianM-C
Copy link
Contributor

The pot recipes for ensemble still use linear indexing in some places. I've updated the places where I saw warnings from, but I'm not sure if I haven't missed something.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (df27cdc) 30.48% compared to head (b01a10d) 39.96%.

Files Patch % Lines
src/ensemble/ensemble_analysis.jl 0.00% 4 Missing ⚠️
src/ensemble/ensemble_solutions.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   30.48%   39.96%   +9.48%     
==========================================
  Files          54       54              
  Lines        4068     4076       +8     
==========================================
+ Hits         1240     1629     +389     
+ Misses       2828     2447     -381     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit cb23cdc into SciML:master Jan 24, 2024
33 of 41 checks passed
@SebastianM-C SebastianM-C deleted the ensemble_plot branch January 24, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants