Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix u0 dependent on p not working with remake #703

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Jun 5, 2024

Close #672

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Needs a test

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.18%. Comparing base (9185795) to head (c0c52ef).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #703       +/-   ##
===========================================
- Coverage   41.53%   31.18%   -10.35%     
===========================================
  Files          55       55               
  Lines        4582     4572       -10     
===========================================
- Hits         1903     1426      -477     
- Misses       2679     3146      +467     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 2e85cb5 into SciML:master Jun 5, 2024
17 of 42 checks passed
@AayushSabharwal AayushSabharwal deleted the as/remake-interdep branch June 6, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remake doesn't evaluate interdependencies between u0 and p
2 participants