-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strip_solution
#762
Add strip_solution
#762
Conversation
Setup downstream tests |
solution stripping.") | ||
end | ||
|
||
interp = strip_interpolation(sol.interp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jClugstor : Just randomly reviewing this. It seems strange to me that the interp
variable isn't used afterwards? Should it go into line 618? Otherwise, what's the point of defining it at all? Also, maybe check that the interpolation is stripped as well in the tests if this is the intended behavior here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that looks like a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's a typo, thanks for pointing it out .
@jClugstor what's the next steps for this? |
This will need to check if the solution was made using an implicit method that has caches, if it was I'll need to strip the cache. Should I make a trait for SciMLAlgs e.g. 'has_cache' ? |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
I know
error(...)
is discouraged, but I couldn't find one that fit, and wasn't sure if I should make one.This also doesn't completely strip solutions made from implicit methods, since the caches still need to be dealt with.