-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom srcdir and update build docs #8
Conversation
Many thanks for helping out! 😄 The only problem I seem to have is that Nimble isn't cooperating really. It complains about |
always forget that syntax... and I actually looked it up 🤷♂️! https://github.com/nim-lang/nimble#nimble-install |
Haha same, I only ever use I tried fixing the path at the top of the page by inserting this code into nbPostInit:
But it doesn't seem to have any effect. I was looking at this piece of code where title is set to |
Oh I see why now: https://github.com/pietroppeter/nimib/blob/4926b61190416ab7b52a42cb5644fffd3163b44d/src/nimib.nim#L51-L54 |
yes, you are right. You should also add a |
had to add also a |
Awesome! I feel ready to merge this now unless you have anything more to add 😄
I'm still trying to wrap my head around how Nimib works internally, so correct me if I'm wrong, do I understand it correctly that |
nothing more to add! yes, you are right, |
mmh, the CI for building docs it seems it ran fine but I do not see the changes reflected in the final result... |
Hmm yeah me neither... I checked the logs and saw this:
So it seems it ignores the hash for some reason :/ Okay nice, good to know 👍 |
Ok, I will release a new nimib and send a follow up PR.
yes, nimib tries to follow nim philosophy as far as I am able to understand it :). The realization that I should just go the nim way ("this is the way") is what actually made me come up with a library and an api instead of a binary file (which will probably eventually come to ease up configuration and scaffolding).
Yes, it could be used to replace the header with some simple navigation common to all pages for example. |
I restarted the Action and now it installed the correct version... No idea what happendde |
Greatly appreciated 🙏
Sounds like a really good realization :) And yes some kind of binary that could replace our
That's neat! |
I think I might add a srcDir mechanism like the above in future versions of nimib to support this workflow out of the box but probably the default srcDir will be named "src".