Remove else in exhaustive case over enums #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove else from exhaustive case statements. In Nim [0.20.0](https://nim-lang.org/blog/2019/06/06/version-0200-released.html) onward, doing an else when switching over an enum after covering all cases will result in an error.
singularperturbation
changed the title
Comment indentation
|
This is unfortunate, since these .nim files are generated using c2nim. I am accepting the PR for now since it is definitely needed, but I wil open an issue against c2nim to avoid generating else clauses for exhaustive checks |
|
Posted an issue here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove else from exhaustive case statements. In Nim 0.20.0 onward, doing an else when switching over an enum after covering all cases will result in an error.