Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run_client.py #148

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update run_client.py #148

merged 1 commit into from
Mar 12, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Mar 12, 2024

fix localhost url


Ellipsis 🚀 This PR description was created by Ellipsis for commit a4ff8cd.

Summary:

This PR updates the base_url in run_client.py to match the server's actual port.

Key points:

  • Updated base_url in run_client.py from http://localhost:8010 to http://localhost:8000

Generated with ❤️ by ellipsis.dev

fix localhost url
@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review March 12, 2024 20:12
@emrgnt-cmplxty emrgnt-cmplxty merged commit b95ff1b into main Mar 12, 2024
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
r2-r 🔄 Building (Inspect) Visit Preview Mar 12, 2024 8:13pm
r2-r-p8la 🔄 Building (Inspect) Visit Preview Mar 12, 2024 8:13pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to a4ff8cd
  • Looked at 14 lines of code in 1 files
  • Took 39 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. r2r/examples/basic/run_client.py:8:
  • Assessed confidence : 50%
  • Comment:
    Please ensure that the server is running on port 8000. If the server is running on a different port, this change would prevent the client from connecting to the server.
  • Reasoning:
    The change in the PR is a simple change of the port number in the base URL from 8010 to 8000. This change seems straightforward, but it's important to verify that the server is indeed running on port 8000 and not on 8010. If the server is running on port 8010, this change would break the client's ability to connect to the server. However, without additional context or access to the server configuration, it's impossible to definitively say whether this change is correct or not. The PR author states that this is a 'fix', implying that the previous port was incorrect. If the author has tested this change and confirmed that the server is running on port 8000, then this change should be fine.

Workflow ID: wflow_HuePed2hL4V2D4xy


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant