fix pydantic breaking change #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 1df2887
- Looked at
20lines of code in1files - Took 46 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
2additional comments because they didn't meet confidence threshold of50%.
1. r2r/main/models.py:92:
- Assessed confidence :
50% - Comment:
Please ensure that 'populate_by_name' is a valid attribute in Pydantic's Config class and that it serves the same purpose as 'allow_population_by_field_name'. If not, this change could introduce bugs. - Reasoning:
The PR author has replaced 'allow_population_by_field_name' with 'populate_by_name' in the Config classes of LogModel and SummaryLogModel. This seems to be a response to a breaking change in Pydantic. I need to check if 'populate_by_name' is a valid attribute in Pydantic's Config class and if it serves the same purpose as 'allow_population_by_field_name'.
2. r2r/main/models.py:111:
- Assessed confidence :
50% - Comment:
Please ensure that 'populate_by_name' is a valid attribute in Pydantic's Config class and that it serves the same purpose as 'allow_population_by_field_name'. If not, this change could introduce bugs. - Reasoning:
The same change has been made in the Config class of SummaryLogModel. I need to make the same comment here for consistency.
Workflow ID: wflow_yjrSIMPju3ouA93A
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the
LogModelandSummaryLogModelclasses inr2r/main/models.pyto replaceallow_population_by_field_namewithpopulate_by_namedue to a Pydantic library update.Key points:
Configclasses inLogModelandSummaryLogModel.allow_population_by_field_namewithpopulate_by_namein both classes.Generated with ❤️ by ellipsis.dev