-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tweak docker build #184
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Reviewed the entire pull request up to 3270848
- Looked at
84
lines of code in3
files - Took 50 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
2
additional comments because they didn't meet confidence threshold of50%
.
1. Dockerfile:13
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
The removal of 'RUN poetry config virtualenvs.create false' could potentially lead to the creation of a virtual environment when running 'poetry install'. It's generally recommended to avoid creating a virtual environment inside Docker containers. Consider adding it back unless there's a specific reason for its removal. - Reasoning:
The Dockerfile has been modified to remove the line 'RUN poetry config virtualenvs.create false'. This could potentially lead to the creation of a virtual environment when running 'poetry install', which may not be the desired behavior in a Docker context. It's generally recommended to avoid creating a virtual environment inside Docker containers, as they add an unnecessary layer of complexity.
2. .github/workflows/build-main.yml:46
:
- Assessed confidence :
66%
- Grade:
0%
- Comment:
The Docker image is being tagged with 'main'. This could potentially lead to confusion if the 'main' tag is also used for the latest stable release. Consider using a different tag for the main branch and the latest stable release to avoid confusion. - Reasoning:
In the GitHub workflow file 'build-main.yml', the Docker image is being tagged with 'main'. This could potentially lead to confusion if the 'main' tag is also used for the latest stable release. It's generally recommended to use a different tag for the main branch and the latest stable release to avoid confusion.
Workflow ID: wflow_dxGN9cO0Fgj9ouMw
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. We'll respond in a few minutes. Learn more here.
run: | | ||
curl -X POST \ | ||
-H "Accept: application/vnd.github.v3+json" \ | ||
-H "Authorization: token ${{ secrets.PERSONAL_ACCESS_TOKEN }}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A personal access token is being used to trigger dependent repositories. This could potentially be a security risk if the token has more permissions than necessary. Consider using a token with the least amount of permissions necessary.
Summary:
This PR introduces a new GitHub Actions workflow for building and pushing Docker images on push to main, simplifies the poetry install command in the Dockerfile, and renames an existing workflow.
Key points:
build-main.yml
.publish-to-docker.yml
tobuild-release.yml
.Generated with ❤️ by ellipsis.dev