Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tweak docker build #184

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Feature/tweak docker build #184

merged 2 commits into from
Mar 17, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Mar 17, 2024

Ellipsis 🚀 This PR description was created by Ellipsis for commit 3270848.

Summary:

This PR introduces a new GitHub Actions workflow for building and pushing Docker images on push to main, simplifies the poetry install command in the Dockerfile, and renames an existing workflow.

Key points:

  • Added new GitHub Actions workflow build-main.yml.
  • Workflow triggers on push to main branch.
  • Workflow sets up Google Cloud SDK and Docker, builds and pushes Docker image, and triggers dependent repositories.
  • Simplified poetry install command in Dockerfile.
  • Renamed publish-to-docker.yml to build-release.yml.

Generated with ❤️ by ellipsis.dev

@emrgnt-cmplxty emrgnt-cmplxty merged commit 122e0cd into main Mar 17, 2024
1 of 2 checks passed
Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
r2r-docs 🔄 Building (Inspect) Visit Preview Mar 17, 2024 2:52am

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Reviewed the entire pull request up to 3270848
  • Looked at 84 lines of code in 3 files
  • Took 50 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 2 additional comments because they didn't meet confidence threshold of 50%.
1. Dockerfile:13:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The removal of 'RUN poetry config virtualenvs.create false' could potentially lead to the creation of a virtual environment when running 'poetry install'. It's generally recommended to avoid creating a virtual environment inside Docker containers. Consider adding it back unless there's a specific reason for its removal.
  • Reasoning:
    The Dockerfile has been modified to remove the line 'RUN poetry config virtualenvs.create false'. This could potentially lead to the creation of a virtual environment when running 'poetry install', which may not be the desired behavior in a Docker context. It's generally recommended to avoid creating a virtual environment inside Docker containers, as they add an unnecessary layer of complexity.
2. .github/workflows/build-main.yml:46:
  • Assessed confidence : 66%
  • Grade: 0%
  • Comment:
    The Docker image is being tagged with 'main'. This could potentially lead to confusion if the 'main' tag is also used for the latest stable release. Consider using a different tag for the main branch and the latest stable release to avoid confusion.
  • Reasoning:
    In the GitHub workflow file 'build-main.yml', the Docker image is being tagged with 'main'. This could potentially lead to confusion if the 'main' tag is also used for the latest stable release. It's generally recommended to use a different tag for the main branch and the latest stable release to avoid confusion.

Workflow ID: wflow_dxGN9cO0Fgj9ouMw


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

run: |
curl -X POST \
-H "Accept: application/vnd.github.v3+json" \
-H "Authorization: token ${{ secrets.PERSONAL_ACCESS_TOKEN }}" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A personal access token is being used to trigger dependent repositories. This could potentially be a security risk if the token has more permissions than necessary. Consider using a token with the least amount of permissions necessary.

@emrgnt-cmplxty emrgnt-cmplxty deleted the feature/tweak-docker-build branch March 17, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant