add get uniq #191
Merged
add get uniq #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 0b281f9
- Looked at
217lines of code in6files - Took 1 minute and 17 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. r2r/main/app.py:296:
- Assessed confidence :
50% - Comment:
Consider adding type hints to the return values of the new endpoints for better clarity and consistency with the rest of the codebase. For example, for theget_user_idsendpoint, you could add-> Dict[str, List[str]]:to the function signature. - Reasoning:
The PR adds a new methodget_all_unique_valuesto theVectorDBProviderabstract base class and its implementations. This method retrieves all unique values for a given metadata field, optionally filtered by other metadata fields. The method is correctly implemented in theLocalVectorDB,PGVectorDB, andQdrantDBclasses. The PR also adds two new endpoints to the FastAPI app:/get_user_ids/and/get_user_documents/, which use the new method to retrieve unique user IDs and document IDs, respectively. The code looks correct, but there are a few minor improvements that could be made.
Workflow ID: wflow_ikZxasOsR7qtGlMv
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| ): | ||
| print("rag_completion") |
There was a problem hiding this comment.
Please remove the print statement. It seems to be a debugging statement and should not be in the production code.
Suggested change
| print("rag_completion") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a new method for retrieving unique values from the database and adds two new endpoints for fetching user IDs and user documents.
Key points:
get_all_unique_valuesmethod inVectorDBProviderand its implementations inLocalVectorDB,PGVectorDB, andQdrantDB./get_user_ids/and/get_user_documents/in FastAPI application.run_client.py.Generated with ❤️ by ellipsis.dev