fix html bug #196
Merged
fix html bug #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 81b79ae
- Looked at
18lines of code in1files - Took 30 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_Yz60K8JK54K7FpZ0
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| return self._parse_html(entry_data) | ||
| if not isinstance(entry_data, bytes): | ||
| raise ValueError("HTML data must be a bytes object.") | ||
| return self._parse_html(entry_data.encode("utf-8")) |
There was a problem hiding this comment.
The change from expecting a string to expecting bytes for HTML data seems unnecessary, as it is immediately encoded back to a string. This could potentially introduce bugs. Consider reverting this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR modifies the
process_datafunction in theBasicIngestionPipelineclass to expect HTML data as a bytes object, which is then encoded to 'utf-8' before parsing.Key points:
process_datafunction inBasicIngestionPipelineclass in/r2r/pipelines/basic/ingestion.py._parse_htmlfunction.Generated with ❤️ by ellipsis.dev