Feature/move to adapter model rebased #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 820bb28
- Looked at
1597lines of code in11files - Took 2 minutes and 25 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. poetry.lock:1:
- Assessed confidence :
100% - Grade:
0% - Comment:
Please update the PR description to include the reason for adding new dependencies (dirtyjson,html2text,llama-hub,llama-index,llama-parse,pymupdf,striprtf,pyaml,retrying). It's important to document why these new dependencies are needed and how they are used in the code. - Reasoning:
The new dependencies added in the poetry.lock file are not mentioned in the PR description. It's important to document why these new dependencies are needed and how they are used in the code.
Workflow ID: wflow_st1dAfArRYBrPG2n
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a new adapter model to the R2R project, updating the
BasicIngestionPipelineto use these adapters for data processing, and includes end-to-end tests for the new functionality.Key points:
Adapterabstract base class and several concrete implementations for different data types (text, JSON, HTML, PDF) inr2r/core/adapters/base.py.BasicIngestionPipelineinr2r/pipelines/basic/ingestion.pyto use the new adapters for data processing.r2r/tests/end_to_end.py.poetry.lockwith new dependencies required by the adapters.Generated with ❤️ by ellipsis.dev