Feature/change eval to post #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃憤 Looks good to me!
- Reviewed the entire pull request up to 11abe71
- Looked at
32lines of code in1files - Took 45 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. r2r/main/app.py:341:
- Assessed confidence :
100% - Grade:
0% - Comment:
The /eval endpoint now expects a request body due to the change from GET to POST. Please ensure that all calls to this endpoint have been updated to include the necessary request body. - Reasoning:
The PR changes the HTTP method from GET to POST for the /eval endpoint and the requests made to it. This is generally a good practice as POST is more suitable for requests that cause changes. However, the /eval endpoint now expects a request body (payload: EvalPayloadModel), which is not typically included in GET requests. The PR author should ensure that all calls to this endpoint have been updated to include the necessary request body.
Workflow ID: wflow_gftEOcabrM3qsGdY
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR modifies the HTTP method for the
/evalendpoint from GET to POST in ther2r/main/app.pyfile, affecting therag_completion,_stream_rag_completion, andevalfunctions.Key points:
/evalendpoint from GET to POST inr2r/main/app.py./evalinrag_completionand_stream_rag_completionfunctions.evalfunction to@app.post.Generated with 鉂わ笍 by ellipsis.dev