Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/change eval to post #234

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Mar 28, 2024

Ellipsis 🚀 This PR description was created by Ellipsis for commit 11abe71.

Summary:

This PR modifies the HTTP method for the /eval endpoint from GET to POST in the r2r/main/app.py file, affecting the rag_completion, _stream_rag_completion, and eval functions.

Key points:

  • Changed HTTP method for /eval endpoint from GET to POST in r2r/main/app.py.
  • Updated requests to /eval in rag_completion and _stream_rag_completion functions.
  • Updated decorator for eval function to @app.post.

Generated with ❤️ by ellipsis.dev

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
r2r-docs 🔄 Building (Inspect) Visit Preview Mar 28, 2024 2:26am

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review March 28, 2024 02:27
@emrgnt-cmplxty emrgnt-cmplxty merged commit 2d96255 into main Mar 28, 2024
1 of 2 checks passed
@emrgnt-cmplxty emrgnt-cmplxty deleted the feature/change-eval-to-post branch March 28, 2024 02:27
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 11abe71
  • Looked at 32 lines of code in 1 files
  • Took 45 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. r2r/main/app.py:341:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The /eval endpoint now expects a request body due to the change from GET to POST. Please ensure that all calls to this endpoint have been updated to include the necessary request body.
  • Reasoning:
    The PR changes the HTTP method from GET to POST for the /eval endpoint and the requests made to it. This is generally a good practice as POST is more suitable for requests that cause changes. However, the /eval endpoint now expects a request body (payload: EvalPayloadModel), which is not typically included in GET requests. The PR author should ensure that all calls to this endpoint have been updated to include the necessary request body.

Workflow ID: wflow_gftEOcabrM3qsGdY


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant