Emrgnt cmplxty patch 2 #255
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to e63ac47
- Looked at
41lines of code in2files - Took 55 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_jvmEZeFb6y8zmgC0
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| CMD ["uvicorn", "r2r.examples.basic.app:app", "--host", "0.0.0.0", "--port", "8000", "--workers", "8"] |
There was a problem hiding this comment.
Consider making the number of workers configurable through an environment variable instead of hardcoding it to '8'. This would allow for more flexibility depending on the server resources available.
| sess.execute(text("create schema if not exists vecs;")) | ||
| except Exception as e: | ||
| if "already exists" not in str(e): | ||
| raise ValueError( |
There was a problem hiding this comment.
Consider raising a more specific error, such as a DatabaseError, instead of a ValueError. This would provide more context about the nature of the error.
| sess.execute(text("create extension if not exists vector;")) | ||
| except Exception as e: | ||
| if "already exists" not in str(e): | ||
| raise ValueError( |
There was a problem hiding this comment.
As mentioned in the previous comment, consider raising a more specific error, such as a DatabaseError, instead of a ValueError.
Summary:
This PR improves the application's performance by increasing the number of uvicorn server workers and adds robust error handling to the database schema and extension creation process.
Key points:
--workers 8to theCMDinstruction in theDockerfileto increase the number of uvicorn server workers.vecsschema andvectorextension creation process in the__init__method of theClientclass inr2r/vecs/client.py.Generated with ❤️ by ellipsis.dev