tweak the client #257
Merged
tweak the client #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 80a6183
- Looked at
41lines of code in1files - Took 1 minute and 6 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. r2r/vecs/client.py:68:
- Assessed confidence :
50% - Comment:
Consider making the schema name a configurable option instead of hardcoding it. This would provide more flexibility if the schema name needs to be different in some cases. - Reasoning:
The MetaData object is being created with a hardcoded schema name 'vecs'. This might not be an issue if the schema name is not expected to change. However, if there's a possibility that the schema name might need to be different in some cases, it would be better to make this a configurable option.
Workflow ID: wflow_ohYhy9qxdLr1oSos
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| @@ -78,7 +82,7 @@ def _initialize_database(self): | |||
| self._create_extension(sess) | |||
| self._get_vector_version(sess) | |||
| return | |||
| except sqlalchemy.exc.OperationalError as e: | |||
| except Exception as e: | |||
There was a problem hiding this comment.
Consider catching specific exceptions that you expect might be thrown in this block of code. Catching a general Exception could potentially hide other issues that are not related to OperationalErrors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enhances error handling and logging in the
Clientclass inclient.pyby importing additional modules and modifying exception handling.Key points:
loggingandtimemodules toclient.py._initialize_databasemethod ofClientclass to catch all exceptions.MetaDatainstantiation inClientclass constructor.Generated with ❤️ by ellipsis.dev