-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ LanceDB integration #350
Conversation
@raghavdixit99 is attempting to deploy a commit to the Sciphi-Team Team on Vercel. A member of the Team first needs to authorize it. |
hi @emrgnt-cmplxty , could you have a look at the dev PR, will raise an official one once I get some clarity on the above as well as the metadata schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Reviewed the entire pull request up to 74e9b5b
- Looked at
945
lines of code in11
files - Took 1 minute and 22 seconds to review
More info
- Skipped
1
files when reviewing. - Skipped posting
0
additional comments because they didn't meet confidence threshold of50%
.
Workflow ID: wflow_WSkosawfqu8bLiwr
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with review rules, user-specific overrides, quiet
mode, and more. See docs.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@emrgnt-cmplxty hey can we get some action on this one? |
Hi,
I have added the code for
LanceDB
vector store class.supports:
TODO : Code cleanup/minor fixes pending along with final schema. Add docs wherever necessary.
Testing :
I tested via adding an example, added
configs/local_ollama_lancedb.json
and tested viarun_test_client.py
.facing an issue in bulk insert have commented the code in
r2r/main/app.py
which I think is causing the issue, storage happens inembedding.py
via upsert_entries, but it is being called sequentially so bulk insert isnt happening, and therun()
method doesnt accept list() it accepts a singleDocumentPage
class.If I am doing something wrong here please let me know, otherwise would need to request some changes in the r2r code.
Thanks
Summary:
Integrates
LanceDB
as a new vector database provider, enhancing the system's capabilities with metadata filtering and addressing bulk insert issues.Key points:
LanceDB
integration for vector storage and retrieval.LanceDB
.Generated with ❤️ by ellipsis.dev