Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Milvus vector db into R2R; All tests passed; support all functions in the interface #392

Closed
wants to merge 23 commits into from

Conversation

Jacksonxhx
Copy link

@Jacksonxhx Jacksonxhx commented Jun 4, 2024

Integrated Milvus vector db into R2R


🚀 This description was created by Ellipsis for commit b5e7b78

Summary:

This PR integrates Milvus as a new vector database provider in the R2R framework, updating documentation, configurations, and adding necessary implementations and tests.

Key points:

  • Added Milvus as a new vector database provider in r2r.
  • Updated documentation in /docs/pages/providers/vector-databases.mdx to include Milvus.
  • Modified VectorDBProvider in r2r/core/providers/vector_db_provider.py to support Milvus.
  • Implemented MilvusVectorDB in r2r/vector_dbs/milvus/milvus_db.py.
  • Updated R2RProviderFactory in r2r/main/r2r_factory.py to create MilvusVectorDB instances.
  • Added tests in tests/test_vector_db.py to cover Milvus integration.

Generated with ❤️ by ellipsis.dev

Copy link

vercel bot commented Jun 4, 2024

@Jacksonxhx is attempting to deploy a commit to the Sciphi-Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to b5e7b78 in 1 minute and 28 seconds

More details
  • Looked at 601 lines of code in 7 files
  • Skipped 1 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_vXd2UATYLAmOH3RC


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

r2r/vector_dbs/milvus/milvus_db.py Outdated Show resolved Hide resolved
@emrgnt-cmplxty
Copy link
Contributor

This is impressive work, thanks for taking the time!

We are currently working through a small refactor to focus on pairing relational data with vector entries - does Milvus have some native support for this?

@zc277584121
Copy link

This is impressive work, thanks for taking the time!

We are currently working through a small refactor to focus on pairing relational data with vector entries - does Milvus have some native support for this?

Hi @emrgnt-cmplxty , thanks for your reviewing. Milvus is good enough to support this scenario. e.g.

  • If the relational data are pure texts like text chunks, we can store them directly in the predefined field or dynamic field
  • If the relational data are something like images or videos, we can associate the image_id or video_id with the raw data.

We are happy to keep with the ongoing refactoring and keep the code updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants