-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated Milvus vector db into R2R; All tests passed; support all functions in the interface #392
Conversation
@Jacksonxhx is attempting to deploy a commit to the Sciphi-Team Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to b5e7b78 in 1 minute and 28 seconds
More details
- Looked at
601
lines of code in7
files - Skipped
1
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_vXd2UATYLAmOH3RC
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
This is impressive work, thanks for taking the time! We are currently working through a small refactor to focus on pairing relational data with vector entries - does Milvus have some native support for this? |
Hi @emrgnt-cmplxty , thanks for your reviewing. Milvus is good enough to support this scenario. e.g.
We are happy to keep with the ongoing refactoring and keep the code updated |
Integrated Milvus vector db into R2R
Summary:
This PR integrates Milvus as a new vector database provider in the R2R framework, updating documentation, configurations, and adding necessary implementations and tests.
Key points:
Milvus
as a new vector database provider inr2r
./docs/pages/providers/vector-databases.mdx
to includeMilvus
.VectorDBProvider
inr2r/core/providers/vector_db_provider.py
to supportMilvus
.MilvusVectorDB
inr2r/vector_dbs/milvus/milvus_db.py
.R2RProviderFactory
inr2r/main/r2r_factory.py
to createMilvusVectorDB
instances.tests/test_vector_db.py
to coverMilvus
integration.Generated with ❤️ by ellipsis.dev