Add better handling for ingesting duplicates #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2658f60 in 43 seconds
More details
- Looked at
245lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_6L6hAdlRx9Vm6gYh
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -289,7 +289,27 @@ async def aingest_documents( | |||
| ) | |||
|
|
|||
| document_infos = [] | |||
| skipped_documents = [] | |||
| processed_documents = [] | |||
| existing_document_ids = [ | |||
There was a problem hiding this comment.
The current approach of fetching all document IDs from the database to check for duplicates can be inefficient, especially with a large number of documents. Consider querying the database for each document ID directly or using a batch query to improve performance and scalability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improved duplicate handling in document and file ingestion functions in
r2r/main/r2r_app.py, ensuring duplicates are skipped and appropriate messages are logged and returned.Key points:
r2r/main/r2r_app.pyfor document and file ingestion.aingest_documentsto skip duplicates and log appropriate messages.aingest_filesto handle duplicate files similarly.HTTPExceptionfor conflicts.ingest_documents_appandingest_files_appto propagateHTTPExceptioncorrectly.Generated with ❤️ by ellipsis.dev