Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve kg docs 2 #456

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Feature/improve kg docs 2 #456

merged 2 commits into from
Jun 14, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jun 14, 2024

🚀 This description was created by Ellipsis for commit f01700a

Summary:

Improved knowledge graph documentation and updated code to use subcategory instead of sub_category.

Key points:

  • Updated docs/pages/cookbooks/knowledge-graph.mdx to improve documentation for knowledge graph construction.
  • Changed sub_category to subcategory in r2r/core/abstractions/document.py and r2r/pipes/kg_storage_pipe.py.
  • Modified Entity class in r2r/core/abstractions/document.py to use subcategory.
  • Updated extract_entities and extract_triples functions in r2r/core/abstractions/document.py to handle subcategory.
  • Adjusted store method in r2r/pipes/kg_storage_pipe.py to use subcategory.

Generated with ❤️ by ellipsis.dev

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
r2r-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 4:53pm

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review June 14, 2024 16:53
@emrgnt-cmplxty emrgnt-cmplxty merged commit 99c7f2e into main Jun 14, 2024
2 of 3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f01700a in 58 seconds

More details
  • Looked at 235 lines of code in 3 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. r2r/pipes/kg_storage_pipe.py:66
  • Draft comment:
    The store method is still referencing sub_category which has been renamed to subcategory in the Entity class. This needs to be updated to avoid runtime errors.
                            properties={"subcategory": entity.subcategory}
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_FdtRjJWKs6yNW2ya


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant