Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply changes from merge conflict #459

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Reapply changes from merge conflict #459

merged 1 commit into from
Jun 14, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jun 14, 2024

🚀 This description was created by Ellipsis for commit ab271fe

Summary:

Re-applied changes lost due to a merge conflict, adding telemetry decorators and improving document ingestion handling in r2r/main/r2r_app.py.

Key points:

  • Added telemetry_event decorator to multiple async functions in r2r/main/r2r_app.py.
  • Improved document ingestion to handle cases where documents already exist.
  • Updated aingest_documents and aingest_files to skip existing documents and log appropriate messages.
  • Modified return values of ingestion functions to include processed and skipped documents.
  • Ensured proper exception handling and logging in ingestion functions.

Generated with ❤️ by ellipsis.dev

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
r2r-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 8:22pm

@NolanTrem NolanTrem merged commit 5dad883 into main Jun 14, 2024
3 checks passed
@NolanTrem NolanTrem deleted the Nolan/ReaddBlast branch June 14, 2024 20:22
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ab271fe in 1 minute and 11 seconds

More details
  • Looked at 365 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. r2r/main/r2r_app.py:303
  • Draft comment:
    The variable version used in the condition seems incorrect. It should be versions which is the parameter of the function. Please verify and correct it if necessary.
                versions is not None
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_AMt2YMhaS3MnPs1D


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant