Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rename kg agent kg search #766

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jul 25, 2024

🚀 This description was created by Ellipsis for commit b752a51

Summary:

Renamed KGAgentSearchPipe to KGSearchSearchPipe across the codebase for consistency in naming conventions.

Key points:

  • Renamed KGAgentSearchPipe to KGSearchSearchPipe in r2r/__init__.py.
  • Updated kg_agent_prompt to kg_search_prompt in r2r/base/providers/kg.py.
  • Modified CLI options from kg_agent_model to kg_search_model in r2r/cli/cli.py.
  • Changed kg_agent_search_pipe to kg_search_search_pipe in r2r/main/abstractions.py.
  • Updated kg_agent_generation_config to kg_search_generation_config in r2r/main/api/client.py.
  • Renamed with_kg_agent_pipe to with_kg_search_pipe in r2r/main/assembly/builder.py.
  • Modified create_kg_agent_pipe to create_kg_search_pipe in r2r/main/assembly/factory.py.
  • Updated prompt names from kg_agent to kg_search in r2r/providers/prompts/defaults.jsonl.
  • Renamed file kg_agent_search_pipe.py to kg_search_search_pipe.py and updated class name inside it.

Generated with ❤️ by ellipsis.dev

@emrgnt-cmplxty emrgnt-cmplxty changed the base branch from main to dev July 25, 2024 22:55
@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review July 25, 2024 22:57
@emrgnt-cmplxty emrgnt-cmplxty merged commit 3dc1b19 into dev Jul 25, 2024
0 of 2 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to b752a51 in 57 seconds

More details
  • Looked at 413 lines of code in 12 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_0QRPuHechAiTQ9rt


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -17,7 +17,7 @@
logger = logging.getLogger(__name__)


class KGAgentSearchPipe(GeneratorPipe):
class KGSearchSearchPipe(GeneratorPipe):
"""
Embeds and stores documents using a specified embedding model and database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class description for KGSearchSearchPipe seems to be incorrect or copied from another class. It currently describes the class as an embedding and storing documents pipe, which does not align with the expected functionality of a search pipe. Please update the description to accurately reflect its purpose.

@emrgnt-cmplxty emrgnt-cmplxty deleted the feature/rename-kg-agent-kg-search branch July 30, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant