Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix dev tests #775

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Feature/fix dev tests #775

merged 2 commits into from
Jul 26, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jul 26, 2024

🚀 This description was created by Ellipsis for commit aebc586

Summary:

Fixed formatting issues, updated configurations, and enhanced test cases across multiple files.

Key points:

  • Fixed minor formatting issues in r2r/__init__.py and r2r/parsers/__init__.py.
  • Updated model version in r2r/examples/configs/local_ollama.json.
  • Changed prompt name in r2r/examples/scripts/advanced_kg_cookbook.py from kg_agent to kg_assistant.
  • Added R2RAssistants import and inclusion in __all__ in r2r/main/__init__.py.
  • Added mock_assistants to AuthService in tests/test_auth.py.
  • Added assistants to R2REngine in tests/test_client.py.
  • Added assistants to IngestionService in tests/test_ingestion_service.py.
  • Updated LiteLLM to LiteLLMProvider in tests/test_llms.py.
  • Fixed formatting and added type hints in r2r/parsers/structured/csv_parser.py and r2r/parsers/structured/xlsx_parser.py.

Generated with ❤️ by ellipsis.dev

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review July 26, 2024 18:31
@emrgnt-cmplxty emrgnt-cmplxty merged commit 396d3b9 into dev Jul 26, 2024
2 of 3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to aebc586 in 48 seconds

More details
  • Looked at 284 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. tests/test_auth.py:75
  • Draft comment:
    The PR introduces R2RAssistants across various test fixtures but does not provide context or modifications to the actual implementation or usage of R2RAssistants. Please clarify the purpose and impact of these changes.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_4pH0xUpmBGCJW6TD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant