Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend the cli provider checks #816

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jul 31, 2024

🚀 This description was created by Ellipsis for commit b27993d

Summary:

Extended CLI provider checks and updated various files to support additional LLM providers, improve error handling, and rename certain classes and functions for consistency.

Key points:

  • Updated compose.yaml to include environment variables for multiple LLM providers (OpenAI, Anthropic, Azure, Google Vertex AI, AWS Bedrock, Groq, Cohere, Anyscale).
  • Changed model name in r2r.json and r2r/base/abstractions/llm.py from gpt-4o to openai/gpt-4o.
  • Renamed rag_assistant to rag_agent in r2r/main/abstractions.py, r2r/main/assembly/builder.py, r2r/main/assembly/factory.py, and r2r/main/services/retrieval_service.py.
  • Added check_llm_reqs function in r2r/cli/utils/docker_utils.py to validate environment variables for LLM providers.
  • Updated r2r/providers/embeddings/litellm.py and r2r/providers/embeddings/ollama.py to improve error handling by raising R2RException with specific error messages.
  • Modified r2r/providers/prompts/defaults.jsonl to rename rag_assistant prompt to rag_agent.

Generated with ❤️ by ellipsis.dev

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review July 31, 2024 21:34
@emrgnt-cmplxty emrgnt-cmplxty merged commit 0ed29ec into dev Jul 31, 2024
2 of 3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b27993d in 1 minute and 4 seconds

More details
  • Looked at 621 lines of code in 12 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. r2r/providers/prompts/defaults.jsonl:13
  • Draft comment:
    The renaming from rag_assistant to rag_agent should be consistently applied across all files. Ensure all references in the codebase are updated to avoid reference errors.

This comment applies to all instances across the codebase where rag_assistant might still be used.

  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_K6plmn0IdTOJiHfd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty deleted the feature/extend-cli-provider-checks branch August 7, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant