Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to disable webservices, closes #64 #74

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Dec 1, 2022

This adds an undocumented option to disable any web-service support in speasy.
As discussed in meeting, this will speedup speasy loading for use-cases where only one web-service is used.

@jeandet jeandet added the enhancement New feature or request label Dec 1, 2022
@jeandet jeandet added this to the v1.0.4 milestone Dec 1, 2022
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
…sts env

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 84.39% // Head: 84.56% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (9463eb3) compared to base (eee0640).
Patch coverage: 96.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   84.39%   84.56%   +0.16%     
==========================================
  Files          44       44              
  Lines        2641     2662      +21     
  Branches      399      404       +5     
==========================================
+ Hits         2229     2251      +22     
  Misses        288      288              
+ Partials      124      123       -1     
Flag Coverage Δ
unittests 83.84% <96.15%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...peasy/core/requests_scheduling/request_dispatch.py 83.46% <96.00%> (+2.15%) ⬆️
speasy/config/__init__.py 95.45% <100.00%> (+0.06%) ⬆️
speasy/core/__init__.py 90.47% <0.00%> (+1.58%) ⬆️
speasy/core/cache/cache.py 82.25% <0.00%> (+1.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@@ -0,0 +1,44 @@
import unittest
import importlib

Check notice

Code scanning / CodeQL

Unused import

Import of 'importlib' is not used.
Copy link

@brenard-irap brenard-irap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for me

@jeandet jeandet merged commit 1faa0b5 into SciQLop:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants