New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Daru::DataTables::DataTable to Daru::View::DataTable #114

Merged
merged 2 commits into from Aug 23, 2018

Conversation

Projects
None yet
3 participants
@Prakriti-nith
Contributor

Prakriti-nith commented Aug 1, 2018

Updated specs and renamed Daru::DataTables::DataTable to Daru::View::DataTable.
This PR runs in parallel with #22 in daru-data_tables, so some of the test cases will not work right now.

@coveralls

This comment has been minimized.

coveralls commented Aug 1, 2018

Pull Request Test Coverage Report for Build 671

  • 4 of 11 (36.36%) changed or added relevant lines in 3 files are covered.
  • 89 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.7%) to 98.552%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/daru/view/adapters/datatables.rb 1 3 33.33%
spec/table_spec.rb 0 2 0.0%
spec/adapters/datatables_spec.rb 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
lib/daru/view.rb 1 98.55%
lib/daru/view/table.rb 1 93.75%
lib/daru/view/adapters/googlecharts/display.rb 2 96.55%
spec/table_spec.rb 4 100.0%
lib/daru/view/adapters/nyaplot/iruby_notebook.rb 4 40.0%
lib/daru/view/adapters/googlecharts.rb 10 91.53%
lib/daru/view/adapters/datatables.rb 11 93.33%
spec/adapters/datatables_spec.rb 56 100.0%
Totals Coverage Status
Change from base Build 660: 0.7%
Covered Lines: 3131
Relevant Lines: 3177

💛 - Coveralls
@Shekharrajak

This comment has been minimized.

Collaborator

Shekharrajak commented Aug 20, 2018

Please finish it as soon as possible.

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Aug 20, 2018

@Shekharrajak I have tried the examples again, I think the PR is fine.

@Prakriti-nith Prakriti-nith referenced this pull request Aug 20, 2018

Merged

Rename datatables #22

@@ -1,6 +1,7 @@
require 'rspec'
require 'simplecov'
require 'daru/view'
require 'daru/data_tables'

This comment has been minimized.

@Shekharrajak

Shekharrajak Aug 21, 2018

Collaborator

Is it required?

This comment has been minimized.

@Prakriti-nith

Prakriti-nith Aug 22, 2018

Contributor

Yes, it is required to run the specs.

@Shekharrajak

We need to change the folder structure of the daru-data_tables . So another PR has to be created for it.

Merging it for now as temporary solution.

@Shekharrajak Shekharrajak merged commit caa71dd into SciRuby:master Aug 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.7%) to 98.552%
Details
@Shekharrajak

This comment has been minimized.

Collaborator

Shekharrajak commented Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment