NArray compatibility #361
Merged
NArray compatibility #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rix.rb. When NArray is installed alongside NMatrix, `require 'nmatrix'` will load NArray's `lib/nmatrix.rb` file. By moving all relevant code from NMatrix's `lib/nmatrix.rb` to `lib/nmatrix/nmatrix.rb`, users can `require 'nmatrix/nmatrix'` to load NMatrix and thus bypass NArray. Note: The order in which code was loaded previously has been preserved.
* Changed `require` to `require_relative`. * Inserted leading `.` to match existing style. * Dropped duplicates `monkeys` and `shortcuts.rb`. Note: The load mechanism for `nmatrix.so` has not been touched as there seem to be some hacks going on that I didn't want to mess with.
|
This is beautiful. Thank you so much. |
|
This works if you know about it, but any project that does a bare Given this, I'd suggest standardizing on one preferred way to require in the docs/readme, and then print a warning when doing Or better yet, enable doing |
agisga
added a commit
to agisga/mixed_models
that referenced
this pull request
Aug 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NArray is installed alongside NMatrix,
require 'nmatrix'will load NArray'slib/nmatrix.rbfile. By moving all relevant code from NMatrix'slib/nmatrix.rbtolib/nmatrix/nmatrix.rb, users canrequire 'nmatrix/nmatrix'to load NMatrix and thus bypass NArray. (Related issues: #6, #172 and masa16/narray#39; also SciRuby/rb-gsl#14)requires in an extra commit.Please note that I didn't go the extra mile and set up a test environment locally. I trust that it continues to work, based on the nature of the changes, and let Travis do the rest.