Drop support for Matplotlib < 1.5.1 and NumPy < 1.10 #1041
Conversation
QuLogic
force-pushed
the
mpl-bump
branch
2 times, most recently
from
64d3a6f
to
d2ce4ff
Compare
|
So conda only has Matplotlib 1.5.0 linked against NumPy 1.10; I had to bump that minimum version as well. It was released around the same time, so hopefully that's not a problem. |
QuLogic
changed the title
QuLogic
force-pushed
the
mpl-bump
branch
4 times, most recently
from
01c2170
to
99060d5
Compare
We don't even test with 1.3.0 any more, and 1.4.3 is 3 years old now. Anything older than that is not even easy to install with conda either.
This was released around the same time as Matplotlib 1.5.0.
|
So I just remembered that conda packages mpl 1.5.0 in a broken way, so had to bump to 1.5.1. It came out only a few months after though. |
QuLogic
changed the title
| except AttributeError: | ||
| matplotlib.axes._subplot_classes[GeoAxes] = GeoAxesSubplot | ||
| GeoAxesSubplot = matplotlib.axes.subplot_class_factory(GeoAxes) | ||
| GeoAxesSubplot.__module__ = GeoAxes.__module__ |
There was a problem hiding this comment.
See the comment above; this ensures that we get cartopy.mpl.geoaxes.GeoAxesSubplot instead of some matplotlib path (since by using the subplot_class_factory, it's created there.) Also, see last commit's description.
There was a problem hiding this comment.
I wrote that comment, but didn't write the __module__ part 😃 - so was getting some clarification.
There was a problem hiding this comment.
Ah, well, not using the private API necessitated a small change in how the module path was fixed.
|
Excellent, thanks @QuLogic! |
closes matplotlib#11966 The issue has also been fixed on the cartopy side (SciTools/cartopy#1041) but has not been released yet.
We don't even test with 1.3.0 any more, and 1.4.3 is 3 years old now. Anything older than that is not even easy to install with conda either. I chose 1.5 because it was the last major version to use the old style, but we could go with 2.0 instead.
Not sure if conda will like the package set specified right now; we'll see how well the old build works.