Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of README.md in setup.py, and update README.md to include some badges and an image #1069

Merged
merged 2 commits into from
Jul 25, 2018

Conversation

pelson
Copy link
Member

@pelson pelson commented May 16, 2018

Rationale

Gives a little bit of polish to the README. There is a still a lot that can be done though.

I've tested this at https://test.pypi.org/project/Cartopy/#description. It can also be seen at https://github.com/pelson/cartopy/blob/markdown_readme/README.md.

<a href="https://github.com/SciTools/cartopy/graphs/contributors">
<img src="https://img.shields.io/github/contributors/SciTools/cartopy.svg"
alt="# contributors" /></a>
<a href="https://travis-ci.org/SciTools/cartopy/branches">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This badge looks the same as the TravisCI badge, both are labelled build which is confusing (particularly since one is failing and one is passing, resulting in a confusing outlook for the state of the package).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I agree. The standard CircleCI badge is different, but entirely inconsistent (and to my eye, looks pretty terrible). I'm tempted to simply remove the circle-ci one - we only use it currently for docs building verification, I'm not sure it is that useful as an indicator of good repository management.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's lose the CircleCI one then.

@ajdawson
Copy link
Member

Let's take this now. FWIW I am seeing an issue with loading all the badges, frequently one or two fail to load the image and when you reload the page you'll see another one or two are missing. This may just be load on shields.io or perhaps we have too many badges... In any case, it can be addressed later if needed.

@ajdawson ajdawson merged commit c532daf into SciTools:master Jul 25, 2018
@pelson pelson deleted the markdown_readme branch July 25, 2018 14:52
@pelson
Copy link
Member Author

pelson commented Jul 25, 2018

Thanks @ajdawson. The badges issue relates to badges/shields#1568.

@dopplershift dopplershift added this to the 0.17 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants