Fix crash #1090
Merged
Fix crash #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jul 15, 2018
lib/cartopy/crs.py
Outdated
| len(linear_ring.coords) > 2] | ||
| processed_ls = [sgeom.LinearRing(linear_ring) | ||
| for linear_ring in processed_ls | ||
| if len(linear_ring.coords) > 2 and linear_ring.is_valid] |
There was a problem hiding this comment.
E501 line too long (80 > 79 characters)
stickler-ci
reviewed
Jul 15, 2018
lib/cartopy/crs.py
Outdated
| linear_rings = [sgeom.LinearRing(line) for line in processed_ls] | ||
| processed_ls = [sgeom.LinearRing(linear_ring) | ||
| for linear_ring in processed_ls | ||
| if len(linear_ring.coords) > 2 and linear_ring.is_valid] |
There was a problem hiding this comment.
E501 line too long (80 > 79 characters)
stickler-ci
reviewed
Jul 15, 2018
lib/cartopy/crs.py
Outdated
| linear_rings = [sgeom.LinearRing(line) for line in processed_ls] | ||
| linear_rings = [sgeom.LinearRing(linear_ring) | ||
| for linear_ring in processed_ls | ||
| if len(linear_ring.coords) > 2 and linear_ring.is_valid] |
There was a problem hiding this comment.
E501 line too long (80 > 79 characters)
Don't try to cast to a LinearRing if the source geometry is not valid.
Taken from example posted by @akrherz
|
@pelson Looks like this is all green. |
|
Looks good to me. I've no idea of the performance implications, but happy with the correctness implications 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash with Shapely due to invalid LineString. Seems to be fine just to make sure we have a valid geometry before converting it.
Alternate to #1047 .