Fix incorrect internal use of PlateCarree #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dopplershift
force-pushed
the
fix-2377
branch
2 times, most recently
from
79f3a93
to
0f66f48
Compare
greglucas
approved these changes
Apr 28, 2024
This replaces a couple of internal uses of PlateCarree() for lon/lat coords with more proper geodetic CRS's on the same ellipse, which avoids some precision problems. In the case of LambertConformal, this was resulting in a traceback when creating a boundary on a spherical Earth datum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This replaces a couple of internal uses of PlateCarree() for lon/lat coords with more proper geodetic CRS's on the same ellipse, which avoids some precision problems. In the case of LambertConformal, this was resulting in a traceback when creating a boundary on a spherical Earth datum.
This also fixes another case doing the same thing, seemingly without problem, but it seems better to avoid
PlateCarree()here too.Fixes #2377.
Implications